Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - refactor: use the new homology API for the four and the five lemmas #9022

Closed
wants to merge 7 commits into from

Conversation

joelriou
Copy link
Collaborator

@joelriou joelriou commented Dec 13, 2023

This PR refactors the four and the five lemmas so as to use the new homology API. The files Algebra.Homology.ShortExact.Abelian and Algebra.Homology.ShortExact.Preadditive are also removed because the content of these files has become redundant with the new homology API.


Open in Gitpod

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@joelriou joelriou added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review labels Dec 14, 2023
@joelriou joelriou added awaiting-review and removed awaiting-author A reviewer has asked the author a question or requested changes labels Dec 14, 2023
Copy link
Member

@riccardobrasca riccardobrasca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice refactor, thanks!

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Dec 21, 2023
mathlib-bors bot pushed a commit that referenced this pull request Dec 21, 2023
…9022)

This PR refactors the four and the five lemmas so as to use the new homology API. The files `Algebra.Homology.ShortExact.Abelian` and `Algebra.Homology.ShortExact.Preadditive` are also removed because the content of these files has become redundant with the new homology API.



Co-authored-by: Joël Riou <37772949+joelriou@users.noreply.github.com>
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Dec 21, 2023

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title refactor: use the new homology API for the four and the five lemmas [Merged by Bors] - refactor: use the new homology API for the four and the five lemmas Dec 21, 2023
@mathlib-bors mathlib-bors bot closed this Dec 21, 2023
@mathlib-bors mathlib-bors bot deleted the four-lemma branch December 21, 2023 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors. t-category-theory Category theory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants