Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore(Analysis): rename closedUnitBall and closed_unit_ball to unitClosedBall #9755

Closed
wants to merge 4 commits into from
Closed

[Merged by Bors] - chore(Analysis): rename closedUnitBall and closed_unit_ball to unitClosedBall #9755

wants to merge 4 commits into from

Conversation

eric-wieser
Copy link
Member

@eric-wieser eric-wieser commented Jan 15, 2024 •
edited by YaelDillies
Loading

Since closedBall is a function name, it should appear as an unbroken token in the lemma name

Zulip poll

Open in Gitpod

@eric-wieser eric-wieser added awaiting-CI t-analysis Analysis (normed *, calculus) labels Jan 15, 2024
@eric-wieser eric-wieser changed the title chore(Analsis): rename closedUnitBall and closed_unit_ball to unit_closedBall chore(Analysis): rename closedUnitBall and closed_unit_ball to unit_closedBall Jan 15, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Feb 4, 2024
@fpvandoorn fpvandoorn added the awaiting-author A reviewer has asked the author a question or requested changes label Apr 5, 2024
@YaelDillies YaelDillies force-pushed the eric-wieser/rename-closedBall-lemmas branch from af8d8e6 to 0bb584b Compare November 29, 2024 15:28
@YaelDillies YaelDillies removed awaiting-author A reviewer has asked the author a question or requested changes merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) labels Nov 29, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 29, 2024 •
edited
Loading

PR summary 6e4fd228de

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ StrictConvexSpace.of_strictConvex_unitClosedBall
+ addHaar_unitClosedBall_eq_addHaar_unitBall
+ inv_norm_smul_mem_unitClosedBall
+ sSup_unitClosedBall_eq_nnnorm
+ sSup_unitClosedBall_eq_norm
+ smul_unitClosedBall
+ smul_unitClosedBall_of_nonneg
+ unitClosedBall_eq_univ_of_discrete

You can run this locally as follows 
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@eric-wieser eric-wieser added the please-adopt Inactive PR (would be valuable to adopt) label Nov 29, 2024
@eric-wieser
Copy link
Member Author

I think this needs reworking per the zulip conclusions

@YaelDillies
Copy link
Collaborator

... which I have already done. Sorry however I did forget to update the PR title

@YaelDillies YaelDillies changed the title chore(Analysis): rename closedUnitBall and closed_unit_ball to unit_closedBall chore(Analysis): rename closedUnitBall and closed_unit_ball to unitClosedBall Dec 1, 2024
@YaelDillies YaelDillies self-assigned this Dec 1, 2024
@YaelDillies YaelDillies removed the please-adopt Inactive PR (would be valuable to adopt) label Dec 1, 2024
grunweg
grunweg approved these changes Dec 1, 2024
View reviewed changes
Copy link
Collaborator

@grunweg grunweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add deprecation aliasses for these lemmas, please? Otherwise, LGTM.

eric-wieser and others added 2 commits December 1, 2024 22:17
@eric-wieser @YaelDillies
chore(Analysis): rename closedUnitBall and closed_unit_ball to `u…
1836731 
…nit_closedBall`

Since `closedBall` is a function name, it should appear as an unbroken token in the lemma name
@YaelDillies
deprecated aliases
4fa01ee
@YaelDillies YaelDillies force-pushed the eric-wieser/rename-closedBall-lemmas branch from 0bb584b to 4fa01ee Compare December 1, 2024 22:18
sgouezel
sgouezel reviewed Dec 11, 2024
View reviewed changes
Copy link
Contributor

@sgouezel sgouezel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+
Thanks!

Mathlib/MeasureTheory/Measure/Lebesgue/EqHaar.lean Outdated Show resolved Hide resolved
Mathlib/MeasureTheory/Measure/Lebesgue/EqHaar.lean Outdated Show resolved Hide resolved
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Dec 11, 2024

✌️ eric-wieser can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@YaelDillies YaelDillies added the auto-merge-after-CI Please do not add manually. Requests for a bot to merge automatically once CI is done. label Dec 18, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

As this PR is labelled auto-merge-after-CI, we are now sending it to bors:

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the ready-to-merge This PR has been sent to bors. label Dec 18, 2024
mathlib-bors bot pushed a commit that referenced this pull request Dec 18, 2024
@eric-wieser @YaelDillies
chore(Analysis): rename closedUnitBall and closed_unit_ball to `u…
79dae4b 
…nitClosedBall` (#9755)

Since `closedBall` is a function name, it should appear as an unbroken token in the lemma name

[Zulip poll](https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/unit_closedBall.20or.20unitClosedBall/near/412926794)



Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Dec 18, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(Analysis): rename closedUnitBall and closed_unit_ball to unitClosedBall [Merged by Bors] - chore(Analysis): rename closedUnitBall and closed_unit_ball to unitClosedBall Dec 18, 2024
@mathlib-bors mathlib-bors bot closed this Dec 18, 2024
@mathlib-bors mathlib-bors bot deleted the eric-wieser/rename-closedBall-lemmas branch December 18, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgouezel sgouezel sgouezel left review comments

@grunweg grunweg grunweg approved these changes

Assignees

@YaelDillies YaelDillies

Labels
auto-merge-after-CI Please do not add manually. Requests for a bot to merge automatically once CI is done. delegated ready-to-merge This PR has been sent to bors. t-analysis Analysis (normed *, calculus)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@eric-wieser @YaelDillies @leanprover-community-mathlib4-bot @grunweg @sgouezel @fpvandoorn