Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider making WorkspaceClientCapabilities.applyEdit field Optionable #4541

Closed
onriv opened this issue Jun 23, 2024 · 0 comments · Fixed by #5224
Closed

Consider making WorkspaceClientCapabilities.applyEdit field Optionable #4541

onriv opened this issue Jun 23, 2024 · 0 comments · Fixed by #5224
Labels
bug Something isn't working P-low We are not planning to work on this issue

Comments

@onriv
Copy link

onriv commented Jun 23, 2024

Description

Currently, the field applyEdit in the structure WorkspaceClientCapabilities is with type Bool and hence it cannot be misssing, link to source. Yet from the specification specification-3-16/#clientCapabilities it seems nullable.

Context

This is from the zulip thread disucssing Lean LSP extensions.
@onriv onriv added the bug Something isn't working label Jun 23, 2024
@leanprover-bot leanprover-bot added the P-low We are not planning to work on this issue label Aug 9, 2024
pzread added a commit to pzread/lean4 that referenced this issue Sep 1, 2024
@pzread
fix: make applyEdit optional in ClientCapabilities of LSP
cf63479 
The applyEdit field should be optional in ClientCapabilities by the LSP spec
and some clients don't populate it in requests

Close leanprover#4541
@pzread pzread mentioned this issue Sep 1, 2024
Merged
pzread added a commit to pzread/lean4 that referenced this issue Sep 1, 2024
@pzread
fix: make applyEdit optional in ClientCapabilities of LSP
2bd9222 
The applyEdit field should be optional in ClientCapabilities by the LSP spec
and some clients don't populate it in requests

Close leanprover#4541
pzread added a commit to pzread/lean4 that referenced this issue Sep 1, 2024
@pzread
fix: make applyEdit optional in WorkspaceClientCapabilities of LSP
1d54f7b 
The `applyEdit` field should be optional in `WorkspaceClientCapabilities` by the
LSP spec and some clients don't populate it in requests

Closes leanprover#4541
github-merge-queue bot pushed a commit that referenced this issue Oct 16, 2024
@pzread
fix: make applyEdit optional in WorkspaceClientCapabilities of LSP (#…
b333de1 
…5224)

The `applyEdit` field should be optional in
`WorkspaceClientCapabilities` by the LSP spec and some clients don't
populate it in requests

Closes #4541
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working P-low We are not planning to work on this issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: make applyEdit optional in WorkspaceClientCapabilities of LSP pzread/lean4
2 participants
@onriv @leanprover-bot