Work around VS Code completion bug #1885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kha
commented
Nov 26, 2022
| (notFoundX := pure { items := #[], isIncomplete := true }) fun snap => do | ||
| (notFoundX := | ||
| -- work around https://github.com/microsoft/vscode/issues/155738 | ||
| pure { items := #[{label := "-"}], isIncomplete := true }) fun snap => do |
There was a problem hiding this comment.
Note that the the completion item should not be observable in practice as a follow-up didChange notification that should come with its own completion request must already be received to end up in this branch.
gebner
force-pushed
the
vs-code-completion
branch
from
0ab2dca to
e283a9a
Compare
gebner
requested changes
Nov 29, 2022
Kha
force-pushed
the
vs-code-completion
branch
from
e283a9a to
f231d6b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on top of #1884
Fixes #1858
I consider this a clear bug on VS Code's part: microsoft/vscode#155738