fix: handle SIGBUS when looking for stack overflows #4971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this change, a stack overflow on Mac OS during tactic execution can lead to the message: terminated by signal SIGBUS (Misaligned address error) This comes from the `lean_alloc_small`. With the change, the process instead terminates with the more accurate and actionable: Stack overflow detected. Aborting.
david-christiansen
added
the
release-ci
github-actions
bot
added
the
toolchain-available
|
Mathlib CI status (docs):
|
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 19, 2024
Such handlers can come from address sanitizers and similar. When combined with #4971, this forward-ports rust-lang/rust@676b9bc / rust-lang/rust#69685 --------- Co-authored-by: Sebastian Ullrich <sebasti@nullri.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this change, a stack overflow on Mac OS during tactic execution can lead to the message:
This comes from
lean_alloc_small. With the change, the process instead terminates with the more accurate and actionable: