Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: rename Array.data to Array.toList #5288

Merged
merged 4 commits into from
Sep 10, 2024
Merged

feat: rename Array.data to Array.toList #5288

merged 4 commits into from
Sep 10, 2024

Conversation

kim-em
Copy link
Collaborator

@kim-em kim-em commented Sep 9, 2024 •
edited
Loading

Also renames the current Array.toList to Array.toListImpl. (This function should barely be used.)

See previous discussion on zulip. (I had managed to miss that discussion, thanks @nomeata for pointing it out. Happily what I've done here mostly agrees with the consensus there!)

@github-actions github-actions bot added the changes-stage0 Contains stage0 changes, merge manually using rebase label Sep 9, 2024
@kim-em kim-em added the awaiting-mathlib We should not merge this until we have a successful Mathlib build label Sep 9, 2024
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Sep 9, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Sep 9, 2024
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#5288
e3c2e65
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Sep 9, 2024
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#5288
3700376
@leanprover-community-bot
Copy link
Collaborator

Mathlib CI status (docs):

leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Sep 9, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#5288
0aec919
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Sep 9, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#5288
f7c4a2f
@leanprover-community-bot
Copy link
Collaborator

Mathlib CI status (docs):

@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc September 9, 2024 12:25 Inactive
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Sep 9, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#5288
c048e9e
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Sep 9, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#5288
6a40b12
@leanprover-community-bot
Copy link
Collaborator

Mathlib CI status (docs):

kim-em added a commit to leanprover-community/batteries that referenced this pull request Sep 9, 2024
@kim-em
fixes for leanprover/lean4#5288
14c6365
kim-em added a commit to leanprover-community/mathlib4 that referenced this pull request Sep 9, 2024
@kim-em
fixes for leanprover/lean4#5288
4a3f033
kim-em added a commit to leanprover-community/mathlib4 that referenced this pull request Sep 9, 2024
@kim-em
fixes for leanprover/lean4#5288
9fcf70d
@leanprover-community-bot
Copy link
Collaborator

Mathlib CI status (docs):

@leanprover-community-bot leanprover-community-bot removed the awaiting-mathlib We should not merge this until we have a successful Mathlib build label Sep 9, 2024
@leanprover-community-bot
Copy link
Collaborator

Mathlib CI status (docs):

@leanprover-community-bot leanprover-community-bot added the builds-mathlib CI has verified that Mathlib builds against this PR label Sep 9, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Sep 10, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#5288
2b573b3
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Sep 10, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#5288
0936b79
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc September 10, 2024 03:28 Inactive
@leanprover-community-bot
Copy link
Collaborator

Mathlib CI status (docs):

@kim-em kim-em enabled auto-merge September 10, 2024 05:09
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc September 10, 2024 05:21 Inactive
@kim-em kim-em added this pull request to the merge queue Sep 10, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 10, 2024
@kim-em kim-em merged commit c79b09f into master Sep 10, 2024
13 checks passed
@leanprover-community-mathlib4-bot
Copy link
Collaborator

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 6aa0c46b04e78011af49eb4f272ea07e9173e584 --onto c96fbdda44c14c7c256f046fb2b71fae25ea968e. (2024-09-10 05:24:51)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hargoniX hargoniX Awaiting requested review from hargoniX hargoniX is a code owner

@TwoFX TwoFX Awaiting requested review from TwoFX TwoFX is a code owner

@digama0 digama0 Awaiting requested review from digama0 digama0 is a code owner

@tydeu tydeu Awaiting requested review from tydeu tydeu is a code owner

Assignees
No one assigned
Labels
builds-mathlib CI has verified that Mathlib builds against this PR changes-stage0 Contains stage0 changes, merge manually using rebase toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kim-em @leanprover-community-bot @leanprover-community-mathlib4-bot