fix: have Lake
not create core aliases into Lake
namespace
#5688
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces
export Lean (Name NameMap)
andexport System (SearchPath FilePath)
with the relevantopen
commands. This fixes docgen output so that it can refer to, for example,Lean.Name
instead ofLake.Name
.The reason for these
export
s was convenience: by doingopen Lake
you could get these aliases for free. However, aliases affect pretty printing, and the Lake aliases took precedence. We don't want to disable pretty printing re-exported names because this can be a valid pattern (names could incrementally get re-exported from namespace to parent namespace).In the future we might implement a feature to be able to
scoped open
some names.Breaking change: Lakefiles that refer to
FilePath
may need to change this toSystem.FilePath
or otherwise addopen System (FilePath)
.Closes #2524