-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: constant folding for Nat.ble and Nat.blt #6087
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
!bench |
Here are the benchmark results for commit a2d37c6. Benchmark Metric Change
================================================================
+ big_omega.lean MT branch-misses -1.7% (-18.8 σ)
+ nat_repr branches -1.3% (-1777.3 σ)
+ nat_repr instructions -1.9% (-2472.1 σ)
- rbmap instructions 5.9% (404.2 σ)
- rbmap_1 instructions 1.6% (16.6 σ)
- rbmap_1 task-clock 5.7% (13.6 σ)
- rbmap_1 wall-clock 5.7% (13.6 σ)
- rbmap_10 instructions 4.5% (93.7 σ)
- rbmap_fbip task-clock 12.5% (11.8 σ)
- rbmap_fbip wall-clock 12.5% (12.0 σ)
- rbmap_library instructions 4.7% (296.0 σ)
- stdlib dsimp 1.2% (67.4 σ)
- stdlib fix level params 1.1% (32.2 σ)
- stdlib process pre-definitions 1.1% (18.8 σ) |
github-actions
bot
added
the
toolchain-available
A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
label
Nov 15, 2024
Mathlib CI status (docs):
|
!bench |
Here are the benchmark results for commit e6ca7b5. Benchmark Metric Change
===========================================================
- bv_decide_inequality.lean branch-misses 1.2% (15.8 σ)
- bv_decide_mul wall-clock 2.4% (11.6 σ)
- simp_arith1 branch-misses 3.1% (20.3 σ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
changelog-compiler
Compiler, runtime, and FFI
toolchain-available
A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in the constant folding for the
Nat.ble
andNat.blt
function in the old code generator, leading to a miscompilation.Closes #6086