Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: nontermination while generating equation lemmas for match-expressions #6180

Merged
merged 1 commit into from
Nov 23, 2024

Conversation

leodemoura
Copy link
Member

This PR fixes a non-termination bug that occurred when generating the match-expression equation theorems. The bug was triggered when the proof automation for the equation theorem repeatedly applied injection( to the same local declaration, as it could not be removed due to forward dependencies. See issue #6067 for an example that reproduces this issue.

closes #6067

…essions

This PR fixes a non-termination bug that occurred when generating the
match-expression equation theorems. The bug was triggered when the proof
automation for the equation theorem repeatedly applied `injection(` to
the same local declaration, as it could not be removed due to forward
dependencies. See issue #6067 for an example that reproduces this issue.

closes #6067
@leodemoura leodemoura added the changelog-language Language features, tactics, and metaprograms label Nov 22, 2024
@leodemoura leodemoura requested a review from kim-em as a code owner November 22, 2024 23:25
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc November 22, 2024 23:49 Inactive
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Nov 22, 2024
@leanprover-community-bot
Copy link
Collaborator

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 1126407d9b8358248ccf2f6bdc36787633c40887 --onto 6202461a21d2636129cb8950cd9b6549ccf4b185. (2024-11-22 23:56:13)

@leodemoura leodemoura added this pull request to the merge queue Nov 23, 2024
Merged via the queue into master with commit 4a69643 Nov 23, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-language Language features, tactics, and metaprograms toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(kernel) constant has already been declared during simp
2 participants