Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: lake: detailed Reservoir fetch error #6231

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

tydeu
Copy link
Member

@tydeu tydeu commented Nov 27, 2024

This PR improves the errors Lake produces when it fails to fetch a dependency from Reservoir. If the package is not indexed, it will produce a suggestion about how to require it from GitHub.

Closes #5330.

@tydeu tydeu added the changelog-lake Lake label Nov 27, 2024
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Nov 27, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Nov 27, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Nov 27, 2024
@tydeu tydeu marked this pull request as ready for review November 27, 2024 02:56
@leanprover-community-bot leanprover-community-bot added the builds-mathlib CI has verified that Mathlib builds against this PR label Nov 27, 2024
@leanprover-community-bot
Copy link
Collaborator

Mathlib CI status (docs):

@kim-em
Copy link
Collaborator

kim-em commented Nov 27, 2024

Looks great, thank you!

@tydeu tydeu added this pull request to the merge queue Nov 27, 2024
@tydeu tydeu removed this pull request from the merge queue due to a manual request Nov 27, 2024
@tydeu tydeu added this pull request to the merge queue Nov 27, 2024
Merged via the queue into leanprover:master with commit 04f80a1 Nov 27, 2024
25 checks passed
Copy link
Contributor

The backport to releases/4.14.0 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-releases/4.14.0 releases/4.14.0
# Navigate to the new working tree
cd .worktrees/backport-releases/4.14.0
# Create a new branch
git switch --create backport-6231-to-releases/4.14.0
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 04f80a1f9fde402acbbbd9e480928d919bbd0bc0
# Push it to GitHub
git push --set-upstream origin backport-6231-to-releases/4.14.0
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-releases/4.14.0

Then, create a pull request where the base branch is releases/4.14.0 and the compare/head branch is backport-6231-to-releases/4.14.0.

Copy link
Contributor

The backport to releases/v4.14.0 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-releases/v4.14.0 releases/v4.14.0
# Navigate to the new working tree
cd .worktrees/backport-releases/v4.14.0
# Create a new branch
git switch --create backport-6231-to-releases/v4.14.0
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 04f80a1f9fde402acbbbd9e480928d919bbd0bc0
# Push it to GitHub
git push --set-upstream origin backport-6231-to-releases/v4.14.0
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-releases/v4.14.0

Then, create a pull request where the base branch is releases/v4.14.0 and the compare/head branch is backport-6231-to-releases/v4.14.0.

@kim-em
Copy link
Collaborator

kim-em commented Nov 27, 2024

I've cherry-picked manually onto releases/v4.14.0

kim-em pushed a commit that referenced this pull request Nov 27, 2024
This PR improves the errors Lake produces when it fails to fetch a
dependency from Reservoir. If the package is not indexed, it will
produce a suggestion about how to require it from GitHub.

Closes #5330.
@tydeu tydeu deleted the lake/reservoir-fetch-error branch November 28, 2024 07:23
kim-em pushed a commit that referenced this pull request Nov 29, 2024
This PR improves the errors Lake produces when it fails to fetch a
dependency from Reservoir. If the package is not indexed, it will
produce a suggestion about how to require it from GitHub.

Closes #5330.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport releases/v4.14.0 builds-mathlib CI has verified that Mathlib builds against this PR changelog-lake Lake toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lake: could not materialize package
3 participants