fix: revertAll must clear auxiliary declarations
#6386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leodemoura
added
the
changelog-language
github-actions
bot
added
the
toolchain-available
|
Mathlib CI status (docs):
|
This PR ensures that `revertAll` clears auxiliary declarations when invoked directly by users. closes #6263
leodemoura
force-pushed
the
issue_6263
branch
from
c930fc4 to
b31003b
Compare
eric-wieser
reviewed
Dec 15, 2024
| return mvar.mvarId! | ||
| let (_, mvarId) ← mvarId.revert toRevert | ||
| (preserveOrder := true) | ||
| (clearAuxDeclsInsteadOfRevert := true) |
There was a problem hiding this comment.
Does this do anything in the presence of the for above? (or perhaps I should ask, does the loop above do anything in the presence of this flag?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that
revertAllclears auxiliary declarations when invoked directly by users.closes #6263