Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: require 0 < Range.step #6391

Merged
merged 5 commits into from
Dec 15, 2024
Merged

chore: require 0 < Range.step #6391

merged 5 commits into from
Dec 15, 2024

Conversation

kim-em
Copy link
Collaborator

@kim-em kim-em commented Dec 15, 2024

This PR requires that the step size in Std.Range is positive, to avoid ill-specified behaviour.

@kim-em kim-em added the changelog-library Library label Dec 15, 2024
@kim-em kim-em requested a review from leodemoura as a code owner December 15, 2024 10:34
@kim-em kim-em enabled auto-merge December 15, 2024 10:36
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc December 15, 2024 10:48 Inactive
@kim-em kim-em added this pull request to the merge queue Dec 15, 2024
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Dec 15, 2024
@leanprover-community-bot
Copy link
Collaborator

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 474adc8c9e1d8bfed9003acbc68ec143d0519433 --onto a8a160b09147c3225150703ac727eea6ee9a3b0e. (2024-12-15 10:58:44)

@kim-em kim-em removed this pull request from the merge queue due to a manual request Dec 15, 2024
@kim-em kim-em enabled auto-merge December 15, 2024 11:20
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc December 15, 2024 11:31 Inactive
@kim-em kim-em added this pull request to the merge queue Dec 15, 2024
Merged via the queue into master with commit 80fb404 Dec 15, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leodemoura leodemoura Awaiting requested review from leodemoura leodemoura is a code owner

Assignees
No one assigned
Labels
changelog-library Library toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kim-em @leanprover-community-bot