feat: runtime primitives for mpz objects #6395
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tydeu
force-pushed
the
lean-mpz-primitives
branch
3 times, most recently
from
69ed417 to
4a08e12
Compare
github-actions
bot
added
the
toolchain-available
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Dec 16, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Dec 16, 2024
|
Mathlib CI status (docs):
|
leanprover-community-bot
added
the
builds-mathlib
|
Recall that we should be able to build Lean with and without GMP: https://github.com/leanprover/lean4/blob/master/src/CMakeLists.txt#L77 |
|
@leodemoura Yep! The good news is that these primitives are abstracted above the MPZ implementation. (They work with either GMP or our homegrown multiple precision integer implementation.) |
tydeu
force-pushed
the
lean-mpz-primitives
branch
from
e453b34 to
ea15ca7
Compare
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Dec 16, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Dec 16, 2024
tydeu
force-pushed
the
lean-mpz-primitives
branch
from
ea15ca7 to
dc5e674
Compare
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Dec 16, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a basic C API interface for Lean MPZ objects. It includes constructors, conversions, and comparison operators.
These primitives are necessary to correctly and efficiently model runtime MPZ objects in Lean.
Where applicable, existing APIs were adjusted to use the new interface.