Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: permit Lake failures in PR release CI #6403

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tydeu
Copy link
Member

@tydeu tydeu commented Dec 16, 2024

This PR allows the PR release CI to succeed even if Lake fails to update Mathlib's version of Batteries.

This can occur if Lake fails to configure the package due to configuration file errors, such as those that may be caused by changes in the PR. This happened, for instance, in #6388.

@tydeu tydeu added the changelog-no Do not include this PR in the release changelog label Dec 16, 2024
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Dec 16, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Dec 16, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Dec 16, 2024
@leanprover-community-bot leanprover-community-bot added the builds-mathlib CI has verified that Mathlib builds against this PR label Dec 16, 2024
@leanprover-community-bot
Copy link
Collaborator

Mathlib CI status (docs):

@tydeu tydeu marked this pull request as ready for review December 16, 2024 21:52
@tydeu tydeu requested a review from kim-em as a code owner December 16, 2024 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
builds-mathlib CI has verified that Mathlib builds against this PR changelog-no Do not include this PR in the release changelog toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants