Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ghost goals in autoparam tactic block #6408

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

mhuisi
Copy link
Contributor

@mhuisi mhuisi commented Dec 17, 2024

This PR fixes a regression where goals that don't exist were being displayed. The regression was triggered by #5835 and originally caused by #4926.

Bug originally reported at https://leanprover.zulipchat.com/#narrow/channel/270676-lean4/topic/tactic.20doesn't.20change.20primary.20goal.20state/near/488957772.

The cause of this issue was that #5835 made certain SourceInfos canonical, which was directly transferred to several TacticInfos by #4926. The goal state selection mechanism would then pick up these extra TacticInfos.

The approach taken by this PR is to ensure that the SourceInfo that is being transferred by #4926 is noncanonical.

@mhuisi mhuisi requested a review from kmill December 17, 2024 11:02
@mhuisi mhuisi added the changelog-server Language server, widgets, and IDE extensions label Dec 17, 2024
@mhuisi mhuisi force-pushed the mhuisi/ghost-goals branch from e196913 to 99a0899 Compare December 17, 2024 11:11
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Dec 17, 2024
@leanprover-community-bot
Copy link
Collaborator

Mathlib CI status (docs):

  • ❗ Batteries CI can not be attempted yet, as the nightly-testing-2024-12-17 tag does not exist there yet. We will retry when you push more commits. If you rebase your branch onto nightly-with-mathlib, Batteries CI should run now. (2024-12-17 11:35:48)

@mhuisi mhuisi added this pull request to the merge queue Dec 17, 2024
Merged via the queue into leanprover:master with commit dc24ebd Dec 17, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-server Language server, widgets, and IDE extensions toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants