Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run linter on CI #19

Closed
mauricioabreu opened this issue Jan 15, 2024 · 5 comments
Closed

Run linter on CI #19

mauricioabreu opened this issue Jan 15, 2024 · 5 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@mauricioabreu
Copy link
Collaborator

mauricioabreu commented Jan 15, 2024

Is your feature request related to a problem? Please describe.
No.

Describe the solution you'd like
We already have a command to run the linter locally. It would be great if the linter could run on CI.
Today we have a considerable amount of warnings, I'm not sure if we should fix them or apply some kind of checkpoint (to run the linter after a specific commit.

@mauricioabreu mauricioabreu added the good first issue Good for newcomers label Jan 15, 2024
@luiscovelo
Copy link
Collaborator

Well,

I would like to remove all of warnings that can possible, in my option, we can to add this verification before the build stage.
Later, we can create a conduct code or similar thing, for those who want contribute to the project, follow the rules.

@mauricioabreu
Copy link
Collaborator Author

@luiscovelo agreed!

@mauricioabreu
Copy link
Collaborator Author

@luiscovelo do you plan to open another PR incluind the linter in the CI workflow?

@luiscovelo
Copy link
Collaborator

@mauricioabreu,

Yes, i'll work on it as soon as possible.

@luiscovelo luiscovelo self-assigned this Jan 16, 2024
@luiscovelo
Copy link
Collaborator

See this pull request #22.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants