Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add linter process in ci workflow #22

Merged
merged 10 commits into from
Jan 16, 2024

Conversation

luiscovelo
Copy link
Collaborator

@luiscovelo luiscovelo commented Jan 16, 2024

Hi @mauricioabreu,

I added the linter process into CI workflow, for now, we have 3 stages into 1 job:

  • Test
  • Lint
  • Build

I don't use the just lint command already exists, because i used the golangci-lint image from github.

I needed to override the out-format in args to force show the line code and file affected, then in github actions for default don't have showing, same to describe in .golangci.yml.

output format in golangci.yml

See that issue about this problem.

So, this way, worked very well.

@luiscovelo luiscovelo closed this Jan 16, 2024
@luiscovelo luiscovelo reopened this Jan 16, 2024
Copy link
Collaborator

@mauricioabreu mauricioabreu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! 🎉

@mauricioabreu mauricioabreu merged commit e283856 into learn-video:main Jan 16, 2024
1 check passed
@luiscovelo luiscovelo deleted the ci/lint-workflow branch January 18, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants