Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to pydantic >= 2.0 #613
Migrate to pydantic >= 2.0 #613
Changes from 29 commits
24aabf8
62bd489
8801689
78cfaed
51542ed
b254425
945176a
6ca96f4
5cfe829
917eda7
c968b58
c1dc7e2
42aa111
6f43d74
46efb9b
3045008
d4a4d26
055d1ce
df9f4e9
a55e527
3d3e444
bc5a52f
32a1c68
cdb3de8
3e22780
eba80fa
a8ae34b
84e225d
5a8c31f
47d932c
da4d798
3cd9d38
d3593eb
19004cc
b2d95c8
ad080ed
6df0176
13bfad3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This version is quite recent, can you provide any reasoning behind how it was chosen? Maybe we can bump to just 2.0? Ideally, we should even keep backwards compatibility with older versions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I chose this version because it was the highest possible version I could use, which was still compatible with all of the tests. Remember: the whole reason we're upgrading Pydantic is because this old version has been conflicting with other dependencies, in other projects.
We can revert to 2.0.0 if you still want me to do that, though 2.5.3 seems to be working fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO, If the code is still compatible with pydantic v1 it might be worth it to just do
pydantic>1.8.1