Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dockerfile, fix compatibility with PyTorch>=2.3.0 #614

Merged
merged 2 commits into from
Jun 9, 2024

Conversation

mryab
Copy link
Member

@mryab mryab commented Jun 9, 2024

The current Dockerfile is based on an outdated version of CUDA, and the Python dependency specification allows Python 3.12 to be installed (which is not supported by Hivemind at the moment). Lastly, this PR fixes an error in hivemind.optim.grad_scaler that emerged to a change in the API of PyTorch by using either torch.amp or torch.cuda.amp depending on the version of PyTorch.

This PR fixes all three issues: to make all of CI workflows pass, both the Python version fix and the torch.amp fix are necessary.

Co-authored-by: Luciferian Ink <LuciferianInk@protonmail.com>
@mryab mryab changed the title Update Docker base image and Python version Update Dockerfile, fix compatibility with PyTorch>=2.3.0 Jun 9, 2024
@mryab mryab requested a review from justheuristic June 9, 2024 17:24
Copy link
Member

@justheuristic justheuristic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mryab mryab merged commit 96f9ba3 into master Jun 9, 2024
13 checks passed
@mryab mryab deleted the fix-dockerfile branch June 9, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants