Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix icon position and remove bad graphics files #553

Merged
merged 4 commits into from
Nov 5, 2024
Merged

Conversation

goblincore
Copy link
Collaborator

@goblincore goblincore commented Nov 5, 2024

Overview

This fixes an issue with the positioning of the photo attachment icon on ios and fixes the category graphics by removing the ones with the bad shadows and replaces the the fake svgs that are just a base64 image wrapped in a svg wrapper with a much smaller png.

Fixes this
Screenshot 2024-11-05 at 2 26 33 PM

and this
Screenshot 2024-11-05 at 2 09 43 PM

and this
Screenshot 2024-11-05 at 2 26 03 PM

🎟 Relevant Jira Issues

📚 What is the context and goal of this PR?

🥴 TL; RL:

💡 Feature Breakdown (screenshots & videos encouraged!)

🛠 Important tradeoffs made:

🔍 Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Chore (refactor, documentation update, etc)

💳 Does This Create Any New Technical Debt? ( If yes, please describe and add JIRA TODOs )

  • No
  • Yes

Testing

🔬 How Can Someone QA This?

📱 🖥 Which devices would you like help testing on?

🧪 Code Coverage

Documentation

📜 Gitbook

📊 Storybook

✅ PR Checklist

  • Related to a Jira issue (create one if not)
  • My code follows style guidelines (eslint / prettier)
  • I have manually tested common end-2-end cases
  • I have reviewed my code
  • I have commented my code, particularly where ambiguous
  • New and existing unit tests pass locally with my changes
  • I have made corresponding changes to gitbook documentation

🚀 Ready to squash-and-merge?:

  • Code is backwards compatible
  • There is not a "Do Not Merge" label on this PR
  • I have thoughtfully considered the security implications of this change.
  • This change does not expose new public facing endpoints that do not have authentication

Copy link

changeset-bot bot commented Nov 5, 2024

🦋 Changeset detected

Latest commit: 1f4d5cd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@learncard/react Patch
@learncard/chapi-example Patch
@learncard/snap-chapi-example Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Nov 5, 2024

Deploy Preview for learn-card-chapi-example canceled.

Name Link
🔨 Latest commit 1f4d5cd
🔍 Latest deploy log https://app.netlify.com/sites/learn-card-chapi-example/deploys/672a71d8577c4e0008f316f3

Copy link

netlify bot commented Nov 5, 2024

Deploy Preview for learncarddocs canceled.

Name Link
🔨 Latest commit 1f4d5cd
🔍 Latest deploy log https://app.netlify.com/sites/learncarddocs/deploys/672a71d858bd0e0008348886

@goblincore goblincore changed the title Fix icon position and remove bad graphics files chore: fix icon position and remove bad graphics files Nov 5, 2024
@goblincore goblincore merged commit 01bb2e5 into main Nov 5, 2024
12 checks passed
@goblincore goblincore deleted the misc-fix branch November 5, 2024 19:28
@github-actions github-actions bot mentioned this pull request Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant