-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update KDS Theme Tokens #782
Update KDS Theme Tokens #782
Conversation
26c6e47
to
4ff7c60
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Alex, this looks great. I added just a couple of very small comments. I'm going to try testing this out with one of our custom themed plugins to confirm that everything is working, and then if everything looks good with that I'll approve
docs/pages/menus/index.vue
Outdated
</li> | ||
<li> | ||
Option text hover color: | ||
<DocsInternalLink code text="palette.grey.v_100" href="/colors#palette-grey-v_100" /> | ||
<DocsInternalLink code text="palette.grey.v_200" href="/colors#palette-grey-v_100" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these should both be v_200? Although looking at the docs, I'm not sure that this is meaningfully displayed to the user (not your changes, just in general I'm not sure how helpful it is or how much of a difference it makes)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoops 😅 Fixed it!
Although looking at the docs, I'm not sure that this is meaningfully displayed to the user
Yes, I think the components specs pages are a little outdated. I just saw that in Appbars for example, we are still using the old palette for the examples.
<p style="margin-left: 60px"> | ||
… | ||
</p> | ||
<DocsColorBlock name="palette.green.v_1000" /> | ||
<DocsColorBlock name="palette.green.v_1100" /> | ||
<DocsColorBlock name="palette.green.v_500" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's replace the
<p style="margin-left: 60px">
…
</p>
with
<DocsColorBlock name="palette.green.v_400" />
(not strictly in scope of the palette changes, but I think there isn't really a need to skip the 400 value. I think the "break" was more about the larger gap in between)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done! I also updated the paragraph above "and segment colors into brightness levels, named <code>v_100</code>, <code>v_200</code>, <code>v_300</code>, <code>v_400</code>, <code>v_500</code>, <code>v_600</code>:"
Thank you @marcellamaki! Just pushed the changes (: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thank you @AlexVelezLl.
When testing with our "cookiecutter" theme plugin, the current version of Kolibri develop breaks, and this fixes it! (Don't mind the ugly test colors :) )
Before | After |
---|---|
Thank you @marcellamaki! |
Description
Update KDS Theme Tokens to the latest specs in #775.
Issue addressed
Closes #775.
Before/after screenshots
Changelog
v_*
theme tokens using the mapping in Update KDS Theme Token values #775.Steps to test
Implementation notes
At a high level, how did you implement this?
Searched for all v_* colors and replaced all of them but
gray.v_400
andgray.v_800
which remained the same.Testing checklist
Reviewer guidance
Comments