fix login modal not shown and "Show More" and capitalize string #711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 67.51% (diff: 100%)@@ vue2 #711 diff @@
==========================================
Files 136 136
Lines 5131 5131
Methods 280 280
Messages 0 0
Branches 601 601
==========================================
Hits 3464 3464
Misses 1607 1607
Partials 60 60
|
66eli77
changed the title
66eli77
changed the title
| @@ -307,6 +307,7 @@ | |||
| border-radius: 40px | |||
| font-size: 0.875em | |||
| display: inline-block | |||
| text-transform: capitalize; | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
indirectlylit
approved these changes
Dec 4, 2016
| @@ -2,13 +2,13 @@ | |||
|
|
|||
| <!--TODO: VUE2 UNTESTED --> | |||
| <div> | |||
| <nav-bar-item v-if="loggedIn" tabindex="0" @click="toggleDropdown" @keyup.enter="toggleDropdown"> | |||
| <nav-bar-item v-if="loggedIn" tabindex="0" @click.native="toggleDropdown" @keyup.enter="toggleDropdown"> | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vue2's new characteristic about how to handle click event, see here for detail vuejs/vue#3253
Also vue2 does not support template filters anymore, details see here vuejs/vue#2756
but for capitalizing string, we should use css solution instead.