fix: review comments

leather-io · Nov 30, 2020 · 6381ad8 · 6381ad8
1 parent 646d52e
commit 6381ad8
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 4 deletions.
diff --git a/app/pages/stacking/step/choose-amount.tsx b/app/pages/stacking/step/choose-amount.tsx
@@ -14,7 +14,7 @@ import { ErrorText } from '@components/error-text';
 import { validateDecimalPrecision } from '@utils/form/validate-decimals';
 import { microStxToStx, stxToMicroStx, toHumanReadableStx } from '@utils/unit-convert';
 
-interface ChooseCycleStepProps {
+interface ChooseAmountStepProps {
   id: string;
   balance: BigNumber;
   step?: number;
@@ -27,7 +27,7 @@ interface ChooseCycleStepProps {
 
 const BigNumberFloorRound = BigNumber.clone({ ROUNDING_MODE: BigNumber.ROUND_FLOOR });
 
-export const ChooseAmountStep: FC<ChooseCycleStepProps> = props => {
+export const ChooseAmountStep: FC<ChooseAmountStepProps> = props => {
   const { isComplete, step, id, value, balance, minimumAmountToStack, onEdit, onComplete } = props;
 
   const stxAmountForm = useFormik({
@@ -65,7 +65,7 @@ export const ChooseAmountStep: FC<ChooseCycleStepProps> = props => {
     const updatedAmount = new BigNumberFloorRound(microStxToStx(balance.toString())).decimalPlaces(
       0
     );
-    stxAmountForm.setValues({ stxAmount: updatedAmount.toString() });
+    void stxAmountForm.setValues({ stxAmount: updatedAmount.toString() });
   }, [balance, stxAmountForm]);
 
   const currentValue =

diff --git a/app/utils/form/validate-decimals.ts b/app/utils/form/validate-decimals.ts
@@ -1,5 +1,9 @@
 import BigNumber from 'bignumber.js';
 
+/**
+ * @description Returns a fn that validates a number is within the specified decimal precision
+ * Useful in conjunction with a form validation schema
+ */
 export function validateDecimalPrecision(allowedPrecision: number) {
   return (value: any) => {
     if (value === null || value === undefined) return false;

diff --git a/app/utils/stacking/pox.spec.ts b/app/utils/stacking/pox.spec.ts
@@ -58,7 +58,7 @@ test.skip('making a lock-stx transaction', async () => {
   });
   await waitForTxConfirm(`0x${lockTxid}`);
   const stackerInfo = await client.getStackerInfo(address);
-  if ('error' in stackerInfo) return;
+  if ('error' in stackerInfo) throw new Error('Contains an error response');
   console.log('Stacker Info:');
   console.log('Amount Locked:', stackerInfo.amountMicroStx);
   console.log('Lock Period:', stackerInfo.lockPeriod);