feat: make type password

leather-io · Sep 25, 2020 · db48935 · db48935
1 parent 8859057
commit db48935
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 7 deletions.
diff --git a/app/modals/transaction/decrypt-wallet-form.tsx b/app/modals/transaction/decrypt-wallet-form.tsx
@@ -23,7 +23,7 @@ export const DecryptWalletForm: Props = args => {
   return (
     <Box mx="extra-loose" mt="extra-loose">
       <Text textStyle="body.large">Enter your password to confirm your transaction</Text>
-      <Input onChange={handlePasswordInput} mt="base-loose" />
+      <Input onChange={handlePasswordInput} type="password" mt="base-loose" />
       {hasSubmitted && decryptionError && (
         <ErrorLabel>
           <ErrorText>Password entered is incorrect</ErrorText>

diff --git a/app/modals/transaction/transaction-modal.tsx b/app/modals/transaction/transaction-modal.tsx
@@ -158,8 +158,6 @@ export const TransactionModal: FC<TxModalProps> = ({ balance, address }) => {
           );
         }
 
-        console.log('tx after changing signature', tx.serialize().toString('hex'));
-
         dispatch(
           broadcastStxTransaction({
             signedTx: tx,
@@ -245,7 +243,7 @@ export const TransactionModal: FC<TxModalProps> = ({ balance, address }) => {
         network: stacksNetwork,
         amount: new BN(stxToMicroStx(form.values.amount).toString()),
         //
-        // TODO: find common burn address
+        // SECURITY: find common burn address
         senderKey: 'f0bc18b8c5adc39c26e0fe686c71c7ab3cc1755a3a19e6e1eb84b55f2ede95da01',
       });
       const { amount, fee } = {
@@ -279,11 +277,11 @@ export const TransactionModal: FC<TxModalProps> = ({ balance, address }) => {
     // if (!form.values.recipient) return;
     setCalculatingMaxSpend(true);
     const demoTx = await makeSTXTokenTransfer({
+      // SECURITY: remove hardcoded test address
       recipient: form.values.recipient || 'ST3NR0TBES0A94R38EJ8TC1TGWPN9T1SHVW03ZBD7',
       network: stacksNetwork,
       amount: new BN(stxToMicroStx(form.values.amount).toString()),
-      //
-      // TODO: find common burn address
+      // SECURITY: find common burn address
       senderKey: 'f0bc18b8c5adc39c26e0fe686c71c7ab3cc1755a3a19e6e1eb84b55f2ede95da01',
     });
     const fee = demoTx.auth.spendingCondition?.fee as BN;
@@ -307,7 +305,6 @@ export const TransactionModal: FC<TxModalProps> = ({ balance, address }) => {
       header: <TxModalHeader onSelectClose={closeModalResetForm}>Send STX</TxModalHeader>,
       body: (
         <>
-          {/* ST4VFKC1WG386T43ZSMWTVM9TQGCXHR3R1VF99RV */}
           <TxModalForm
             balance={balance}
             form={form}