Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[4.0.0-beta.5] Bug: Infinite spinner when creating a new wallet, CSP PR has broken login #312

Closed
timstackblock opened this issue Oct 30, 2020 · 4 comments
Closed

[4.0.0-beta.5] Bug: Infinite spinner when creating a new wallet, CSP PR has broken login #312

timstackblock opened this issue Oct 30, 2020 · 4 comments
Assignees
@timstackblock
Labels
Bug 🐛 Functionality broken P1 Bug 🚨 Critical functionality broken for many customers, with no clear workarounds reported-from-ui

Comments

@timstackblock
Copy link

During the creation of a new wallet once the user enters a password they get an infinite spinner and are stuck on the screen below

Screen Shot 2020-10-30 at 10 26 17 AM

Bug found testing Stacks Wallet build ff021be, Thu Oct 29 12:50:07 UTC 2020.
@timstackblock timstackblock changed the title [4.0.0-beta.5] Bug: Infinite spinner when creating a new waller [4.0.0-beta.5] Bug: Infinite spinner when creating a new wallet Oct 30, 2020
@timstackblock timstackblock added the P1 Bug 🚨 Critical functionality broken for many customers, with no clear workarounds label Oct 30, 2020
@timstackblock timstackblock changed the title [4.0.0-beta.5] Bug: Infinite spinner when creating a new wallet [4.0.0-beta.5] Bug: Infinite spinner when creating a new wallet, CSP PR has broken login Oct 30, 2020
@kyranjamie
Copy link
Collaborator

kyranjamie commented Nov 2, 2020 •
edited
Loading

Good find, @timstackblock —

I've ran into some issues with this PR #299 where things are only breaking in production mode (not even with DEBUG_PROD enabled), which is often the last thing I test. I spent quite a lot of time debugging this on Friday. Electron offers a communication mechanism to bridge the renderer (browser) and main (node) threads. See ipcMain docs on Electron.

I haven't found yet what it is enabled in prod that breaks this.

@kyranjamie kyranjamie mentioned this issue Nov 2, 2020
Closed
@markmhendrickson markmhendrickson linked a pull request Nov 4, 2020 that will close this issue
fix: remove 'unsafe-eval' from CSP, closes #126 #299
Closed
@markmhendrickson
Copy link
Collaborator

I'm not experiencing this issue with the build I'm testing. Is that because production mode is off?

@kyranjamie
Copy link
Collaborator

This is specific to the currently broken PR

@timstackblock
Copy link
Author

This is resolved

@timstackblock timstackblock mentioned this issue Dec 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@timstackblock timstackblock

Labels
Bug 🐛 Functionality broken P1 Bug 🚨 Critical functionality broken for many customers, with no clear workarounds reported-from-ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: remove 'unsafe-eval' from CSP, closes #126 leather-io/desktop
3 participants
@markmhendrickson @kyranjamie @timstackblock