fix: remove 'unsafe-eval' from CSP, closes #126 #299
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyranjamie
force-pushed
the
fix/tighten-csp
branch
3 times, most recently
from
fbb3831 to
19a4178
Compare
kyranjamie
force-pushed
the
fix/tighten-csp
branch
5 times, most recently
from
f7aad24 to
2c7c43e
Compare
yknl
reviewed
Oct 29, 2020
kyranjamie
force-pushed
the
fix/tighten-csp
branch
2 times, most recently
from
1cd64c5 to
7472c56
Compare
kyranjamie
force-pushed
the
fix/tighten-csp
branch
from
7472c56 to
4fc9d41
Compare
|
Closing this PR in favour of #331 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An unfortunate style of fix, but it works.
As described in #126, the use of
Functionas a constructor, used byajv-->conf-->electron-store, resulted in the CSP requiring theunsafe-evaldirective.At first, I tried replacing the
electron-storelibrary with an alternative, though sadly none work that well. This is the most popular lib.As we're not using the schema validation features of the library, I was able to prevent the library being bundled with
webpack.IgnorePluginand create an alias to a stub file with the same methods that are called, to avoid any runtime errors.@agraebe found that this PR breaks wallet creation, as an error is thrown trying to use
argon2.wasm, as wasm isn't allowed withoutunsafe-eval. Apparently there'll be awasm-eval, but this isn't in the spec yet.I've tried using
argon2node library and communicating to main process with ipc features of Electron. This seems like the most sensible solution. The library works and I tried a poc implementation. However, owing to the multi-environment build set up, it tries to rebuild the binaries and errors out in the process 🤷✅ Workaround completeThe solution I landed on was to use the same argon2 "browser" library, just in node. It's called a browser lib as that's its intention, but really it's just an argon2 wasm lib. So it runs fine in node, too. It's slightly slower than the argon2-node lib, but circumvents all the build issues.
@timstackblock note the argon2 change only affects code that involves deriving the encryption key from a password, so:
Though the CSP may have wider consequences I'm unaware of
❌ ipc communication broken in production
Reported here #312 It turns out the the
ipcMain.on/ipcMain.handleisn't picking up the event in production-only, so the wallet hangs. Debugging why this is happening, though this in itself is a pain to do.