You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
Not sure whether it's a bug, or it's expected:
After specifying the default config in a subgroups, changing the inner attributes of the default configuration requires prior specification within the subgroups.
To Reproduce
The same code in the example provided in subgroups.
$ python issue.py --model model_a --model.lr 1e-2Config(model=ModelAConfig(lr=0.01, optimizer='Adam', betas=(0.9, 0.999)), dataset=Dataset2Config(data_dir='data/bar', bar=1.2))
$ python issue.py --model.lr 1e-2. % I was expecting this to work given that both model configs have `lr` attributeConfig(model=ModelAConfig(lr=0.0003, optimizer='Adam', betas=(0.9, 0.999)), dataset=Dataset2Config(data_dir='data/bar', bar=1.2))
$ python issue.py --model model_a --model.betas 0. 1.Config(model=ModelAConfig(lr=0.0003, optimizer='Adam', betas=(0.0, 1.0)), dataset=Dataset2Config(data_dir='data/bar', bar=1.2))
$ python issue.py --model.betas 0. 1. % ModelA being the default, I was expecting this two workConfig(model=ModelAConfig(lr=0.0003, optimizer='Adam', betas=(0.9, 0.999)), dataset=Dataset2Config(data_dir='data/bar', bar=1.2))
Desktop (please complete the following information):
Version 0.0.20
Python version: 3.10
The text was updated successfully, but these errors were encountered:
* Add test to confirm that #160 is fixed
Fixes#160
* Add test to assert that #161 is fixed
Fixes#161
---------
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Describe the bug
Not sure whether it's a bug, or it's expected:
After specifying the default config in a
subgroups
, changing the inner attributes of the default configuration requires prior specification within thesubgroups
.To Reproduce
The same code in the example provided in subgroups.
Desktop (please complete the following information):
The text was updated successfully, but these errors were encountered: