Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add better support for setting defaults from Config files #158

Merged
merged 12 commits into from
Aug 19, 2022
Merged

Add better support for setting defaults from Config files #158

merged 12 commits into from
Aug 19, 2022

Conversation

lebrice
Copy link
Owner

@lebrice lebrice commented Aug 15, 2022 •
edited
Loading

Closes #45

See the example file here:

https://github.com/lebrice/SimpleParsing/blob/config-file/examples/config_files/README.md

@lebrice
Fix set_defaults not working with dataclasses
e5bcf0b 
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
@lebrice
Add config_files, make serialization static
b656d1a 
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
@lebrice
Simplify parse, add links in REAMDE
5c404cd 
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
@lebrice
Add bullet-point in main README for config files
14f9301 
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
@lebrice
Minor touchups
f0220b0 
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
@lebrice
Make all methods redirect to static version
35ea504 
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
@lebrice
Add a TODO comment, change if block
9bd7612 
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
@lebrice
Expose more serialization functions, add utils
21aad65 
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
@lebrice
Improve test, add functions in utils.py
f2aea95 
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
@lebrice
Improve set_defaults method
fc9c3e4 
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
@lebrice
respect add_config_path_arg=False even with config
9e9fd68 
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
@lebrice
Add some tests to test_set_defaults
2a8919c 
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
@lebrice lebrice merged commit 12637d8 into master Aug 19, 2022
@lebrice lebrice deleted the config-file branch August 19, 2022 23:19
@lebrice lebrice mentioned this pull request Aug 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@lebrice