Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for frozen dataclass instances in subgroups #224

Merged
merged 13 commits into from
Mar 1, 2023
Merged

Add support for frozen dataclass instances in subgroups #224

merged 13 commits into from
Mar 1, 2023

Conversation

lebrice
Copy link
Owner

@lebrice lebrice commented Feb 28, 2023

Fixes #223

@lebrice
Update type signature of subgroups function
2c76941 
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
@lebrice
Add test to reproduce #223
79ef477 
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
@lebrice
[temp] Adding support for frozen instance default
2b2ccd9 
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
@lebrice
[temp] Passing the default through
b9bec3d 
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
@lebrice
[wip] Adding support in the parser (tests fail)
d90e734 
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
@lebrice
Update requirement for typing-extensions for py37
ebc80af 
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
@lebrice
Fix the test and the implementation of subgroups
0116e72 
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
@lebrice lebrice marked this pull request as ready for review February 28, 2023 23:33
@lebrice
Clean things up, dont change field default
24dd974 
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
@lebrice
Start to add regression tests for help output
9da78b1 
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
@lebrice
Update the regression file contents
9dd500e 
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
@lebrice
Rename the regression test files
bd8dbcb 
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
@lebrice
Fix issues caused by suppress and dict default
180e4e2 
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
@lebrice
Fix the version req for typing_extensions
465a356 
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
@lebrice lebrice merged commit 8e0ff26 into master Mar 1, 2023
@lebrice lebrice deleted the subgroups_add_frozen_support branch March 1, 2023 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support frozen dataclass instances as subgroup values
1 participant
@lebrice