Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dockerfiles to ubuntu-20.04 and autoconf #215

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Update dockerfiles to ubuntu-20.04 and autoconf #215

wants to merge 4 commits into from

Commits on Jul 20, 2023

  1. Update dockerfiles to ubuntu-20.04 and autoconf 

    The nvidia/cuda:10.2 image disappeared from the hub, so the GPU
versions in master were not buildable anymore.  Also, the two that
build bifrost were not yet using the configure script.

However, the full-build `.gpu` version doesn't quite work because
nvidia-docker seems to provide access to GPU during run phase, but not
during build phase.  Perhaps relevant:
https://stackoverflow.com/questions/59691207/docker-build-with-nvidia-runtime

The `_prereq.gpu` version builds fully and is still helpful.

Also pinging PR #92 which is outdated but relevant.
    @league
    league committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    a8ddfa9 View commit details
    Browse the repository at this point in the history

  2. Dockerfiles: include dependencies needed for tests

    @league
    league committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    bb654f7 View commit details
    Browse the repository at this point in the history

  3. Skip certain tutorial notebook tests when CUDA not enabled 

    Also write `_all_output.ipynb` to temporary dir rather than tutorial
dir, so they don't match the glob again the next time. (Not an issue
on ephemeral containers/CI tests, but with a persistent source dir
they accumulate like `_all_output_all_output_all_output`. :)
    @league
    league committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    4015661 View commit details
    Browse the repository at this point in the history

  4. Conditionalize tests that require scipy

    @league
    league committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    2c73d15 View commit details
    Browse the repository at this point in the history