Update from View.propTypes to ViewPropTypes to match RN v0.44.0 #406

TBouder · 2017-05-09T07:29:26Z

Update the ViewPropTypes to match the last revision of React Native V0.44.0

View.propTypes to ViewPropTypes (53905a5) - @bvaughn

https://github.com/facebook/react-native/releases

gusgard · 2017-05-11T18:06:18Z

+1

jhalborg · 2017-05-30T09:16:20Z

Can someone please merge this in so we can get rid of this bloody warning? :) react-navigation/react-navigation#1352

samanthacampisi · 2017-06-06T10:44:49Z

Please merge this. It's not a big change but it's necessary.

adriaferre · 2017-06-06T10:47:51Z

Please merge!

breogangf · 2017-06-06T10:48:23Z

You should merge this guys

nehvaleem · 2017-06-08T17:15:39Z

+1 for merge as soon as possible

adrienthiery · 2017-06-09T12:13:35Z

@leecade : Anything we can do to help merging this?

BANG88 · 2017-06-13T02:57:30Z

I switch to the latest RN this morning ,seems its an error now, so this definitely needs to repair.

jhalborg · 2017-06-13T07:20:22Z

@leecade @leecades - Can you, or one of your friends who help maintain this great library, please have a look at this pull request soon? Thanks

samanthacampisi

seems ok

breogangf

We can merge it, everything seems fine

fungilation · 2017-06-17T10:48:41Z

A bit strange that I didn't see warnings at RN 0.44, but they are showing now after upgrade to RN 0.45?

console:

Warning: PropTypes has been moved to a separate package. Accessing React.PropTypes is no longer supported and will be removed completely in React 16. Use the prop-types package on npm instead. (https://fb.me/migrating-from-react-proptypes)
reactConsoleErrorHandler	@	ExceptionsManager.js:71
printWarning	@	warning.js:36
warning	@	warning.js:60
get	@	react.development.js:2133
(anonymous)	@	index.js:101
loadModuleImplementation	@	require.js:174
guardedLoadModule	@	require.js:126
_require	@	require.js:110
(anonymous)	@	index.js:1
loadModuleImplementation	@	require.js:174
guardedLoadModule	@	require.js:126
_require	@	require.js:110
(anonymous)	@	components.js:28
loadModuleImplementation	@	require.js:174
guardedLoadModule	@	require.js:126
_require	@	require.js:110
(anonymous)	@	index.ios.js:85
loadModuleImplementation	@	require.js:174
guardedLoadModule	@	require.js:119
_require	@	require.js:110
(anonymous)	@	redux-logger.js:1
executeApplicationScript	@	debuggerWorker.js:40
(anonymous)	@	debuggerWorker.js:65

18:29:38.112 ExceptionsManager.js:71 Warning: React.createClass is no longer supported. Use a plain JavaScript class instead. If you're not yet ready to migrate, create-react-class is available on npm as a drop-in replacement. (https://fb.me/migrating-from-react-create-class)
reactConsoleErrorHandler @ ExceptionsManager.js:71
printWarning @ warning.js:36
warning @ warning.js:60
get @ react.development.js:2125
(anonymous) @ View.js:84
loadModuleImplementation @ require.js:174
guardedLoadModule @ require.js:126
_require @ require.js:110
get View @ react-native-implementation.js:56
(anonymous) @ index.js:103
loadModuleImplementation @ require.js:174
guardedLoadModule @ require.js:126
_require @ require.js:110
(anonymous) @ index.js:1
loadModuleImplementation @ require.js:174
guardedLoadModule @ require.js:126
_require @ require.js:110
(anonymous) @ components.js:28
loadModuleImplementation @ require.js:174
guardedLoadModule @ require.js:126
_require @ require.js:110
(anonymous) @ index.ios.js:85
loadModuleImplementation @ require.js:174
guardedLoadModule @ require.js:119
_require @ require.js:110
(anonymous) @ redux-logger.js:1
executeApplicationScript @ debuggerWorker.js:40
(anonymous) @ debuggerWorker.js:65

18:29:38.116 ExceptionsManager.js:71 Warning: View.propTypes has been deprecated and will be removed in a future version of ReactNative. Use ViewPropTypes instead.
reactConsoleErrorHandler @ ExceptionsManager.js:71
printWarning @ warning.js:36
warning @ warning.js:60
get @ View.js:185
(anonymous) @ index.js:103
loadModuleImplementation @ require.js:174
guardedLoadModule @ require.js:126
_require @ require.js:110
(anonymous) @ index.js:1
loadModuleImplementation @ require.js:174
guardedLoadModule @ require.js:126
_require @ require.js:110
(anonymous) @ components.js:28
loadModuleImplementation @ require.js:174
guardedLoadModule @ require.js:126
_require @ require.js:110
(anonymous) @ index.ios.js:85
loadModuleImplementation @ require.js:174
guardedLoadModule @ require.js:119
_require @ require.js:110
(anonymous) @ redux-logger.js:1
executeApplicationScript @ debuggerWorker.js:40
(anonymous) @ debuggerWorker.js:65
18:29:38.429 

Warning: checkPropTypes has been moved to a separate package. Accessing React.checkPropTypes is no longer supported and will be removed completely in React 16. Use the prop-types package on npm instead. (https://fb.me/migrating-from-react-proptypes)
reactConsoleErrorHandler	@	ExceptionsManager.js:71
console.error	@	YellowBox.js:67
printWarning	@	warning.js:36
warning	@	warning.js:60
get	@	react.development.js:2117
(anonymous)	@	index.ios.bundle?platform=ios&dev=true&minify=false:38714
loadModuleImplementation	@	require.js:174
guardedLoadModule	@	require.js:119
_require	@	require.js:110
get LayoutAnimation	@	react-native-implementation.js:83
checkClipboard$	@	components.js:1213
tryCatch	@	runtime.js:63
invoke	@	runtime.js:337
prototype.(anonymous function)	@	runtime.js:96
tryCatch	@	runtime.js:63
invoke	@	runtime.js:139
(anonymous)	@	runtime.js:147
tryCallOne	@	core.js:37
(anonymous)	@	core.js:123
(anonymous)	@	JSTimers.js:117
callTimer	@	JSTimersExecution.js:95
callImmediatesPass	@	JSTimersExecution.js:199
callImmediates	@	JSTimersExecution.js:214
(anonymous)	@	MessageQueue.js:223
__guard	@	MessageQueue.js:213
__callImmediates	@	MessageQueue.js:223
(anonymous)	@	MessageQueue.js:121
__guard	@	MessageQueue.js:213
invokeCallbackAndReturnFlushedQueue	@	MessageQueue.js:119
(anonymous)	@	debuggerWorker.js:71

The first 3 warnings all trace at (anonymous) @ components.js:28, with line:
import Swiper from 'react-native-swiper'

sabbyt · 2017-06-28T07:48:33Z

+1

jhalborg · 2017-06-28T15:05:34Z

What seems to be the officer, problem? :) The merge seems to have been approved over two weeks ago now?

adrienthiery · 2017-06-28T15:56:58Z

Ping @samanthacampisi @breogangf ? Do you have the rights to merge ?

zachrnolan · 2017-06-28T18:01:06Z

Would love to see this merged! Is this project still being maintained?

mackenzie-gray · 2017-06-28T20:16:06Z

+1 to get this merged!

fungilation · 2017-07-06T03:50:24Z

@leecade, at least a heads up if you don't have time to maintain this?

LostCrew · 2017-07-14T14:13:07Z

Please, merge!

bvaughn · 2017-07-14T14:43:16Z

There's a lot of comments asking for merge. Why keep adding duplicates? This project is MIT. Fork it.

ryanvanderpol · 2017-07-18T21:10:41Z

+1

@bvaughn cause we're lazy and want to use the existing npm package instead of creating a whole new set of dependencies to maintain and potentially have to switch back later on.

fungilation · 2017-08-04T03:47:47Z

A lingering warning still on RN 0.47.1:

ExceptionsManager.js:73 Warning: PropTypes has been moved to a separate package. Accessing React.PropTypes is no longer supported and will be removed completely in React 16. Use the prop-types package on npm instead. (https://fb.me/migrating-from-react-proptypes)
reactConsoleErrorHandler @ ExceptionsManager.js:73
printWarning @ warning.js:35
warning @ warning.js:59
get @ react.development.js:2133
(anonymous) @ index.js:101
loadModuleImplementation @ require.js:174
guardedLoadModule @ require.js:126
_require @ require.js:110
(anonymous) @ index.js:1
loadModuleImplementation @ require.js:174
guardedLoadModule @ require.js:126
_require @ require.js:110
(anonymous) @ components.js:30
loadModuleImplementation @ require.js:174
guardedLoadModule @ require.js:126
_require @ require.js:110
(anonymous) @ index.ios.js:88
loadModuleImplementation @ require.js:174
guardedLoadModule @ require.js:119
_require @ require.js:110
(anonymous) @ redux-logger.js:1
executeApplicationScript @ debuggerWorker.js:40
(anonymous) @ debuggerWorker.js:65

ExceptionsManager.js:73 Warning: React.createClass is no longer supported. Use a plain JavaScript class instead. If you're not yet ready to migrate, create-react-class is available on npm as a drop-in replacement. (https://fb.me/migrating-from-react-create-class)
reactConsoleErrorHandler @ ExceptionsManager.js:73
printWarning @ warning.js:35
warning @ warning.js:59
get @ react.development.js:2125
(anonymous) @ ToolTip.ios.js:24
loadModuleImplementation @ require.js:174
guardedLoadModule @ require.js:126
_require @ require.js:110
(anonymous) @ components.js:53
loadModuleImplementation @ require.js:174
guardedLoadModule @ require.js:126
_require @ require.js:110
(anonymous) @ index.ios.js:88
loadModuleImplementation @ require.js:174
guardedLoadModule @ require.js:119
_require @ require.js:110
(anonymous) @ redux-logger.js:1
executeApplicationScript @ debuggerWorker.js:40
(anonymous) @ debuggerWorker.js:65
20:13:15.465

Unless you are telling me you can't reproduce these warnings in any RN >= 0.45 project?

mrdezzods · 2017-08-04T19:49:51Z

Sorry for the trouble guys. I will be maintaining this package from now on.

This issue has been resolved with #483

adrienthiery · 2017-08-04T20:58:34Z

Thanks @mrdezzods ! 👏

fungilation · 2017-08-04T21:06:58Z

Hurray this package is alive again! Some nice PRs pending ;)

Upd nativapp: fork repo to rn44 with viewprops edit

a73f2e7

leethree mentioned this pull request May 12, 2017

[RN 0.44] Warning: View.propTypes has been deprecated... #401

Closed

samanthacampisi approved these changes Jun 13, 2017

View reviewed changes

breogangf approved these changes Jun 13, 2017

View reviewed changes

mrdezzods closed this Aug 4, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update from View.propTypes to ViewPropTypes to match RN v0.44.0 #406

Update from View.propTypes to ViewPropTypes to match RN v0.44.0 #406

TBouder commented May 9, 2017

gusgard commented May 11, 2017

jhalborg commented May 30, 2017

samanthacampisi commented Jun 6, 2017

adriaferre commented Jun 6, 2017

breogangf commented Jun 6, 2017

nehvaleem commented Jun 8, 2017

adrienthiery commented Jun 9, 2017

BANG88 commented Jun 13, 2017

jhalborg commented Jun 13, 2017

samanthacampisi left a comment

breogangf left a comment

fungilation commented Jun 17, 2017

sabbyt commented Jun 28, 2017

jhalborg commented Jun 28, 2017

adrienthiery commented Jun 28, 2017

zachrnolan commented Jun 28, 2017

mackenzie-gray commented Jun 28, 2017

fungilation commented Jul 6, 2017

LostCrew commented Jul 14, 2017

bvaughn commented Jul 14, 2017

ryanvanderpol commented Jul 18, 2017

fungilation commented Aug 4, 2017

mrdezzods commented Aug 4, 2017

adrienthiery commented Aug 4, 2017

fungilation commented Aug 4, 2017

Update from View.propTypes to ViewPropTypes to match RN v0.44.0 #406

Update from View.propTypes to ViewPropTypes to match RN v0.44.0 #406

Conversation

TBouder commented May 9, 2017

gusgard commented May 11, 2017

jhalborg commented May 30, 2017

samanthacampisi commented Jun 6, 2017

adriaferre commented Jun 6, 2017

breogangf commented Jun 6, 2017

nehvaleem commented Jun 8, 2017

adrienthiery commented Jun 9, 2017

BANG88 commented Jun 13, 2017

jhalborg commented Jun 13, 2017

samanthacampisi left a comment

Choose a reason for hiding this comment

breogangf left a comment

Choose a reason for hiding this comment

fungilation commented Jun 17, 2017

sabbyt commented Jun 28, 2017

jhalborg commented Jun 28, 2017

adrienthiery commented Jun 28, 2017

zachrnolan commented Jun 28, 2017

mackenzie-gray commented Jun 28, 2017

fungilation commented Jul 6, 2017

LostCrew commented Jul 14, 2017

bvaughn commented Jul 14, 2017

ryanvanderpol commented Jul 18, 2017

fungilation commented Aug 4, 2017

mrdezzods commented Aug 4, 2017

adrienthiery commented Aug 4, 2017

fungilation commented Aug 4, 2017