lib: fix worker threads can't read stdout

Fix: nodejs#24636
leeight · Nov 26, 2018 · d2beb1c · d2beb1c
1 parent e958ee7
commit d2beb1c
Showing 1 changed file with 12 additions and 2 deletions.
diff --git a/lib/internal/worker.js b/lib/internal/worker.js
@@ -343,12 +343,22 @@ class Worker extends EventEmitter {
       case messageTypes.STDIO_PAYLOAD:
       {
         const { stream, chunk, encoding } = message;
-        return this[kParentSideStdio][stream].push(chunk, encoding);
+        if (this[kParentSideStdio]) {
+          this[kParentSideStdio][stream].push(chunk, encoding);
+        } else {
+          debug(`[${threadId}] explicitly closes stdout for ${this.threadId}`);
+        }
+        return;
       }
       case messageTypes.STDIO_WANTS_MORE_DATA:
       {
         const { stream } = message;
-        return this[kParentSideStdio][stream][kStdioWantsMoreDataCallback]();
+        if (this[kParentSideStdio]) {
+          this[kParentSideStdio][stream][kStdioWantsMoreDataCallback]();
+        } else {
+          debug(`[${threadId}] explicitly closes stdout for ${this.threadId}`);
+        }
+        return;
       }
     }