Skip to content

Commit

Permalink
Scoverage: don't cache the worker classloader too
Browse files Browse the repository at this point in the history
  • Loading branch information
lefou committed Sep 14, 2021
1 parent acd5317 commit faede3b
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 4 deletions.
5 changes: 4 additions & 1 deletion contrib/scoverage/src/ScoverageReportWorker.scala
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,10 @@ class ScoverageReportWorker {
toolsClassPath,
getClass.getClassLoader
)
scoverageClCache = Some((classloaderSig, cl))
// looks like the worker is not properly closing opened source files,
// which makes repetitive targets under Windows fail
// so we drop the whole worker
// scoverageClCache = Some((classloaderSig, cl))
cl
}

Expand Down
6 changes: 3 additions & 3 deletions contrib/scoverage/test/src/HelloWorldTests.scala
Original file line number Diff line number Diff line change
Expand Up @@ -190,6 +190,6 @@ trait HelloWorldTests extends utest.TestSuite {
object HelloWorldTests extends HelloWorldTests {
override def threadCount: Option[Int] = Some(1)
}
//object HelloWorldParTests extends HelloWorldTests {
// override def threadCount: Some[Int] = Some(4)
//}
object HelloWorldParTests extends HelloWorldTests {
override def threadCount: Some[Int] = Some(4)
}

0 comments on commit faede3b

Please sign in to comment.