-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade viewer to PDF.js v1.6.210 #10
Conversation
2) updated "pdf.js.patch" with the required diffs for PDF.js v1.6.210
I have tested your changes with our angular-pdfjs-viewer demo. It looks good but a couple of things aren't working anymore. Since we do not have automatic tests we will have to manually tests that things aren't broken. Can you please verify/fix the following:
Also, it would have been a lot clearer and easier for the reviewing process to make the patches on the actual source code of mozilla. I made a fork here. Could you add the patches onto the source code? Based on that we can generate the two files (pdf.js, pdf.worker.js) that this project depends on. We could then keep the fork easily up to date with the upstream of mozilla. |
2) fixed LOAD button 3) updated "viewer.html"
You were right, the PRINT button was not working because I have not updated "viewer.html" to reflect the latest changes in pdf.js. The LOAD button was not working because one of the patches was too restrictive (the one that disables change notifications for all file-type form elements). I have added one command to "build.sh" which will synchronize "viewer.html" with the latest version from pdf.js |
Updated build script and removed patches
@moesjarraf I merged your changes. |
As requested, I upgraded PDF.js to the current stable version 1.6.210 and then reapplied the patches from the README. Some of them are no more relevant so I updated the README accordingly. There is a test deployment available on http://test.ivogelov.com/pdf/
There are some warnings in the browser console about undefined localization strings.