Load worker script via XHR and init global scope at the right time #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PDFJS doesn't work in firefox (as of v45 and higher). This is because firefox does not allow workers to be instantiated based on scripts that are on a different origin. I bypassed this by first loading the worker script through XHR (this requires the worker script to be sent with the header
Access-Control-Allow-Origin). I also changed the timing that theglobalScopeis populated (so configuration in angular-pdfjs can be done). It now happens right before thePDFJS.webViewerLoadfunction is called, instead of automatically.Some relevant links.
http://colonelpanic.net/2014/08/using-pdf-js-web-worker-cross-domain-cors/
https://www.fxsitecompat.com/en-CA/docs/2016/loading-cross-origin-worker-now-fires-error-event-instead-of-throwing-worker-in-sandboxed-iframe-no-longer-allowed/