raw.orca cleanup
#314
Merged
raw.orca cleanup
#314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge main including build_raw exception for ReferenceErrors in obj checking
Fix docstrings and add missing type hints in `raw`
Codecov Report
@@ Coverage Diff @@
## main #314 +/- ##
==========================================
+ Coverage 29.84% 33.11% +3.27%
==========================================
Files 75 73 -2
Lines 6494 6184 -310
==========================================
+ Hits 1938 2048 +110
+ Misses 4556 4136 -420
Continue to review full report at Codecov.
|
Do not use mutable data structures for argument defaults. They are created during function definition time. All calls to the function reuse this one instance of that data structure, persisting changes between them.
|
this should be on main not refactor, right? |
jasondet
approved these changes
Jul 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the refactor, we should make sure that only tested, standard-compliant code is part of the codebase. Since I don't think decoders for data takers (handled by ORCA) other than FlashCam will be refactored soon, I'm proposing to:
orca_digitizers.pyandorca_pollers.pyORFlashCamListenerStatusDecoderor raise aNotImplementedErrorlike now.These not-yet-refactored pieces of code should be stored elsewhere, in the meanwhile.