Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross talk correction code for build_evt() #572

Merged
merged 88 commits into from
May 8, 2024
Merged

Conversation

tdixon97
Copy link
Contributor

@tdixon97 tdixon97 commented Apr 22, 2024

This contains code to cross talk correct the energies inside the evt tier. The underlying operations are performed in the evt/modules/cross_talk.py module acting on awkward arrays. The correction is applied recursively in a simple way to GERDA.

  • basic implementation
  • unit tests
  • handling of logic of negative pulses (arbitary)
  • positive polarity cross talk
  • format energies to allow matrix solution
  • fast (matrix algebra) implementation
  • function to compute multiplicity

Copy link

codecov bot commented Apr 22, 2024

Codecov Report

Attention: Patch coverage is 47.84946% with 97 lines in your changes are missing coverage. Please review.

Project coverage is 50.09%. Comparing base (daa9530) to head (18c32c3).
Report is 17 commits behind head on main.

Files Patch % Lines
src/pygama/evt/modules/xtalk.py 62.28% 43 Missing ⚠️
src/pygama/evt/modules/geds.py 0.00% 28 Missing ⚠️
src/pygama/hit/build_hit.py 7.14% 26 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #572      +/-   ##
==========================================
+ Coverage   50.05%   50.09%   +0.03%     
==========================================
  Files          63       59       -4     
  Lines        7581     7749     +168     
==========================================
+ Hits         3795     3882      +87     
- Misses       3786     3867      +81     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gipert gipert added the evt build events from hit data label Apr 22, 2024
@gipert gipert changed the title Cross talk correction in evt tier Cross talk correction code for build_evt() May 8, 2024
@gipert gipert merged commit d53c613 into legend-exp:main May 8, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
evt build events from hit data
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants