add a few upstream gnome commits #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Variables like CINNAMON_SHELL_SESSION_MODE may not always be set at login, causing them to survive between session. Add a list of variables that need to be unset, and explicitly unset them on the systemd side. The list is taken from GDMs list of variables. See: GNOME/gnome-session@b7b24627
Specifically, systemd only permits " \t\n" and we should stick to the same set of permitted space characters. See also systemd/systemd#17378 Fixes issue with not filtering the variables with return characters. See: GNOME/gnome-session@fe22c4ee
systemd cannot be auto-started. Doing this avoids warnings during login of the gdm user where we (intentionally) cannot use systemd. See: GNOME/gnome-session@87d92fec
It seems that the pattern we use will create a subpattern match for every character of the value. This appears to then result in a stack overflow when matching very long values. It might be an idea to limit the overall length of an environment variable that is uploaded. But, this should fix the issue of crashes. Fixes a stack overflow caused by long environment variables. See: GNOME/gnome-session@3b57d117
Commit 646b9bc (included in 3.33.92) prevented one run of gnome-session from uploading environment variables into `systemd --user` that should not leak into a different login session, such as XDG_SESSION_ID. However, non-GNOME session managers (and in particular the forks of gnome-session found in Cinnamon and MATE) might still upload those environment variables. The other session managers should be fixed, similar to 646b9bc, but we can mitigate this for GNOME sessions by actively unsetting the undesired variables, instead of just not setting them. Stops innapropriate variables from leaking into later sessions - see https://gitlab.gnome.org/GNOME/gnome-session/-/issues/86 From: GNOME/gnome-session@d44888fb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.