fix: comment has encoded #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leizongmin
reviewed
Apr 17, 2022
lib/default.js
Outdated
| @@ -344,10 +355,12 @@ function onIgnoreTagStripAll() { | |||
| */ | |||
| function StripTagBody(tags, next) { | |||
| if (typeof next !== "function") { | |||
| next = function () {}; | |||
| next = function () { | |||
| }; | |||
| } | |||
leizongmin
added a commit
that referenced
this pull request
Jun 6, 2022
This reverts commit 9f6a37b.
leizongmin
reviewed
Jun 6, 2022
| @@ -228,6 +237,8 @@ function safeAttrValue(tag, name, value, cssFilter) { | |||
| // RegExp list | |||
| var REGEXP_LT = /</g; | |||
| var REGEXP_GT = />/g; | |||
| var REGEXP_LT_NOT_COMMENT = /<(?!!--)/g; | |||
| var REGEXP_RT_NOT_COMMENT = /(?<!--)>/g; | |||
There was a problem hiding this comment.
正则表达式 /(?<!--)>/g 在 Safari 上会报错 SyntaxError: Invalid regular expression: invalid group specifier name，原因是 Safari 不支持 negative lookbehind
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #230