Fix r to work in visual block state
#1036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fukamachi
force-pushed
the
fix/vi-replace-visual-block
branch
from
f949592
to
1c32e5c
Compare
fukamachi
force-pushed
the
fix/vi-replace-visual-block
branch
from
1c32e5c
to
08cb4a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added replace-state at #1033, but it doesn't work in the visual block state because replace-state deletes visual overlays.
Fix it by adding
with-temporary-state, which temporarily enables only the keymap and cursor style without deleting visual overlays.