Include the last newline when kill/copying linewise. #1055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cxxxr
reviewed
Sep 5, 2023
extensions/vi-mode/commands.lisp
Outdated
Comment on lines
289
to
292
| (when (eq type :line) | ||
| (setf (point-charpos (current-point)) | ||
| (max 0 | ||
| (min (1- (length (line-string (current-point)))) pos)))) |
There was a problem hiding this comment.
Direct change of point-charpos is deprecated because it breaks encapsulation.
How about (line-offset (current-point) 0 charpos)?
fukamachi
added a commit
to fukamachi/lem
that referenced
this pull request
Sep 5, 2023
cxxxr
added a commit
that referenced
this pull request
Sep 5, 2023
Fix vi-mode register tests to get along with changes of #1055
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.