Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sdl2 icons workaround #1203

Merged
merged 6 commits into from
Dec 29, 2023
Merged

sdl2 icons workaround #1203

merged 6 commits into from
Dec 29, 2023

Conversation

garlic0x1
Copy link
Collaborator

This fixes #1178

The issue exists on Arch and OpenBSD as far as I am currently aware, the freetype2 package that sdl2_ttf depends on is built without certain options on these systems that break icons in lem.

Using the icon registry, we go from having a pointer error, to just displaying an empty box icon, which is much preferred.

There are probably other icons elsewhere in the source that I haven't run into yet, but the solution is just to add them to src/base/icons.lisp

Before:
image

After:
image

@garlic0x1
Copy link
Collaborator Author

garlic0x1 commented Dec 29, 2023

This change also allows users to change the icons in their config if issues arise, for example, the following will use '>' and 'v' in filer, and 'L' instead of the lock icon:

(register-icon "right-pointing-triangle" #x003E)
(register-icon "down-pointing-triangle" #x0076)
(register-icon "lock" #x004C)

image

@cxxxr cxxxr merged commit aba7dcb into lem-project:main Dec 29, 2023
1 check passed
@cxxxr
Copy link
Member

cxxxr commented Dec 29, 2023

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LEM error
2 participants