-
-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds a recent list to the frame multiplexer + small enhancements. #1229
Adds a recent list to the frame multiplexer + small enhancements. #1229
Conversation
b275417
to
1d949aa
Compare
Maybe the frame-multiplexer is a good place to start with feature keymaps, as described in #1208? I am not sure if such a change would be too disruptive for users, but I would propose to create a new exported variable |
src/ext/frame-multiplexer.lisp
Outdated
(let ((entry (aref (virtual-frame-id/frame-table vf) recent-frame-id))) | ||
(switch-current-frame vf (frame-table-entry-frame entry))))))) | ||
|
||
(define-key *global-keymap* "C-z r" 'frame-mulitplexer-rename) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the current style is to put all the define-key
s at the top of the file, though there is no official rule and I don't know the maintainer's opinion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, I think that is better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed, moved all define-key
s to the top of the file.
I think it's very nice! |
Nothing to add from my side. What do you think about my first comment, should I just create a PR so we can look at it there? |
I agree that users should be able to set a prefix other than C-z. |
Some enhancements for the frame-multiplexer.
New commands:
frame-multiplexer-switch
jump to a frame with the given ID (prefix argument)frame-multiplexer-recent
go to a frame in the recent listframe-multiplexer-rename
give a name to a frameframe-multiplexer-nomalize-ids
re-assign IDs in case many frames have been deleted and created, so it is easier to jump withframe-multiplexer-switch
Changed commands:
frame-multiplexer-next
Accepts a prefix argument with which the jump can get biggerframe-multiplexer-prev
Same as nextframe-multiplexer-delete
Accepts a prefix argument with which a specific frame can be deleted