Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes line rendering for wrapped lines in sdl2 frontend. #1241

Merged

Conversation

mychris
Copy link
Contributor

@mychris mychris commented Jan 7, 2024

I am not sure if this is a complete fix for the rendering in the sdl2 frontend, but it fixes #1240
Maybe render-line should not fill to the end of the line but only to the width of the objects?

Or is it required that the objects given to render-line-with-caching always fill the whole line? If so, then redraw-logical-line-when-line-wrapping needs to be adapted to only call render-line-with-caching once per line.

sdl2-line-wrapping

@mychris mychris marked this pull request as ready for review January 7, 2024 14:58
@cxxxr cxxxr merged commit 21e4a5b into lem-project:main Jan 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with line wrapping with SDL2 frontend
2 participants