Change log-pathname from being set at compile time #1291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fuglesteg
force-pushed
the
refactor-log-pathname
branch
from
e705ea3
to
938e38e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix lsp client to work when built using guix.
The client logs to the file specified by
lem-language-client/request::*log-pathname*This variable is calculated at compile time, and in guix the build environment does not have access to the user directories, which means that the variable is set incorrectly to
/gnu/store/...I imagine this would be preferable to fix anyway, the change makes the variable a bit more resilient to changes in the environment