Vindarel/legit rebase interactive #855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cxxxr
reviewed
Jul 20, 2023
| (message (str:join #\newline (remove-if #'null (list message output))))) | ||
| (let ((msg (str:join #\newline (remove-if #'null (list message output))))) | ||
| (when (str:non-blank-string-p msg) | ||
| (message msg)))) |
There was a problem hiding this comment.
It probably malfunctions if a ~ is included.
There was a problem hiding this comment.
mmh right, but the messages come from porcelain, so it should be fine?
There was a problem hiding this comment.
Hmm, I think it's better to write in a safe way to avoid unnecessary worry.
There was a problem hiding this comment.
That said, it's not enough of a problem to hinder development.
I am very grateful to you for doing such a great job.
|
Thank you for the very nice PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works for the base case, we can pickup/fixup commits, other verbs that need another editing action (edit, reword) don't work.
I wrote up todos and other obvious missing features.
To start a rebase: put the point on a commit, press
r i.Awesome though of course 😎