Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update simplecov dependency to 0.14.1 #117

Merged
merged 4 commits into from
Mar 30, 2017

Conversation

tagliala
Copy link
Contributor

@tagliala tagliala commented Jan 30, 2017

Fix #116

@junaruga
Copy link
Contributor

junaruga commented Feb 1, 2017

I also want to use simplecov 0.13.0 for Ruby 2.4.0 compatibility.
simplecov 0.12.0 stopped by core dump for cucumber Travis Ruby 2.4.0 test.
https://travis-ci.org/cucumber/cucumber-ruby-core/jobs/197417468

@tagliala
Copy link
Contributor Author

tagliala commented Feb 2, 2017

@junaruga

Hi, I don't understand if this PR is ok and my branch fixes your issue or if this doesn't work and I should do something else

@junaruga
Copy link
Contributor

junaruga commented Feb 2, 2017

@tagliala thanks for your quick replying.
ok, as you mentioned, it may not fix my issue as a possibility.
I want coveralls to dump new version with simplecov 0.13, because cucumber-ruby tests are failed for that too.

esigler added a commit to esigler/lita-dig that referenced this pull request Feb 3, 2017
This change introduces an RSpec plugin for RuboCop.  It addresses a few of
the worst offenses, mostly by deleting tests that weren't really doing
anything useful in the first place.

Additionally, until Coveralls gets non-naggy Ruby 2.4 support, I'm pulling
it: lemurheavy/coveralls-ruby#117
@captn3m0
Copy link

@tagliala the PR looks good to me. Can we get this merged? Right now we're allowing build-failures on travis for 2.4.0 because of this

@tagliala
Copy link
Contributor Author

tagliala commented Mar 1, 2017

Hi,

I'm not going to use Ruby 2.4.0 at all, but it would be nice to switch my applications to 2.4.1 asap.

Is there something I can do to speed up things?

@ajm188
Copy link

ajm188 commented Mar 6, 2017

@tagliala what's the ETA on merging this? Not sure what's blocking...

@tagliala tagliala force-pushed the update-simplecov-dependency branch from b936364 to bc984f7 Compare March 15, 2017 09:44
@tagliala tagliala changed the title Update simplecov dependency Update simplecov dependency [W.I.P.] Mar 15, 2017
@tagliala
Copy link
Contributor Author

There is a failing spec with the just released simplecov 0.14.0

  1) Coveralls::SimpleCov::Formatter#format #get_source_files nils the skipped lines
     Failure/Error: source_file[:coverage].should eq [nil, 1, 1, 1, nil, 0, 1, nil, nil, nil]
     
       expected: [nil, 1, 1, 1, nil, 0, 1, nil, nil, nil]
            got: [nil, 1, 1, 1, nil, 0, nil, nil, nil, nil, nil]
     
       (compared using ==)
     # ./spec/coveralls/simplecov_spec.rb:79:in `block (4 levels) in <top (required)>'

I'm trying to take a look

@tagliala
Copy link
Contributor Author

Offending commit: simplecov-ruby/simplecov@d4756e4

Please let me know what is the expected behavior which we would expect from this change

@tagliala tagliala changed the title Update simplecov dependency [W.I.P.] Update simplecov dependency [W.I.P. / DO NOT MERGE] Mar 15, 2017
@tagliala
Copy link
Contributor Author

tagliala commented Mar 15, 2017

I think the new behaviour is the correct one, I will fix specs accordingly

Screenshot (before and after)

image

@tagliala tagliala changed the title Update simplecov dependency [W.I.P. / DO NOT MERGE] Update simplecov dependency Mar 15, 2017
@tagliala
Copy link
Contributor Author

Done.

Looks good to me 👍

@tagliala
Copy link
Contributor Author

Updated to 0.14.1

@tagliala tagliala changed the title Update simplecov dependency Update simplecov dependency to 0.14.1 Mar 19, 2017
@junaruga
Copy link
Contributor

Hi @tagliala

I'm not going to use Ruby 2.4.0 at all, but it would be nice to switch my applications to 2.4.1 asap.

Ruby 2.4.1 was released as a information.
https://www.ruby-lang.org/en/news/2017/03/22/ruby-2-4-1-released/

@tagliala
Copy link
Contributor Author

@junaruga thanks!

I was checking Ruby's website every day. I will try this release and I hope I will not face that issue again

@tagliala tagliala force-pushed the update-simplecov-dependency branch 2 times, most recently from ba0bc03 to 6b4c1a1 Compare March 23, 2017 12:52
@tagliala
Copy link
Contributor Author

Tested against 2.4.1

All green on travis: https://travis-ci.org/lemurheavy/coveralls-ruby/builds/214231009, I hope this could be merged

Ref: travis-ci/travis-ci#7512

@tagliala tagliala force-pushed the update-simplecov-dependency branch from 6b4c1a1 to e652e81 Compare March 29, 2017 17:28
@tagliala
Copy link
Contributor Author

Update: Test against Ruby 2.2.7

@junaruga
Copy link
Contributor

Good day, @nickmerwin or other maintainers.
You may be busy. But can you answer on this PR?
If you have no time for the gem package.
I think that it's time to add co-maintainer newly.

@timbru31
Copy link

This is blocking my project, too :(

@ajm188
Copy link

ajm188 commented Mar 29, 2017

Regarding @junaruga 's comment, I'm happy to come on as a co-maintainer to help out, if you're interested, @nickmerwin

Adds Ruby 2.4.1
Updates 2.2.5 to 2.2.7 and 2.3.1 to 2.3.4
SimpleCov 0.14.0 skip the :nocov: comments along with the code that
they skip. This commit updates a failing spec to reflect that change.

Ref: simplecov-ruby/simplecov@d4756e4
@tagliala tagliala force-pushed the update-simplecov-dependency branch from e652e81 to a3c262f Compare March 30, 2017 08:49
@tagliala
Copy link
Contributor Author

Update: Test against Ruby 2.3.4

Fails because of Travis CI: travis-ci/travis-ci#7535

@ajm188
Copy link

ajm188 commented Mar 30, 2017

@tagliala looks like we're good to merge?

@tagliala
Copy link
Contributor Author

@ajm188 Travis is still not able to test against Ruby 2.3.4, but I'm pretty confident that everything would be fine.

PS: I cannot merge, I'm a contributor because I did a couple of PR in the past, but I'm not a member of this repo.

@nickmerwin
Copy link
Member

Alright this looks great, thank you @tagliala!

@ajm188 I'll contact you over email to talk maintainer-ship 👍

@nickmerwin nickmerwin merged commit 03a8c1d into lemurheavy:master Mar 30, 2017
junaruga added a commit to junaruga/cucumber-ruby that referenced this pull request Mar 30, 2017
Because coveralls 0.8.20 for Ruby 2.4 compatibility was released.
See also lemurheavy/coveralls-ruby#117
@tagliala
Copy link
Contributor Author

@nickmerwin could you please restart the build at https://travis-ci.org/lemurheavy/coveralls-ruby ? 2.3.4 is now available on Travis

@tagliala tagliala deleted the update-simplecov-dependency branch March 30, 2017 18:30
@nickmerwin
Copy link
Member

@tagliala done -- we're green!

@tagliala
Copy link
Contributor Author

Thanks for the merge and the release, my OCD is now satisfied with all those green lights :)

image

junaruga added a commit to junaruga/cucumber-ruby-core that referenced this pull request Mar 31, 2017
Because coveralls 0.8.20 for Ruby 2.4 compatibility was released.
See also lemurheavy/coveralls-ruby#117
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants