Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to trim the value from <Input> #3333

Merged
merged 1 commit into from
Jul 20, 2021
Merged

Add ability to trim the value from <Input> #3333

merged 1 commit into from
Jul 20, 2021

Conversation

Nokel81
Copy link
Collaborator

@Nokel81 Nokel81 commented Jul 9, 2021

  • If set (default = false) then the input will be trimmed of whitespace
    before validation and before submit

  • Use trim on all input's that use the systemName validator

Signed-off-by: Sebastian Malton sebastian@malton.name

fixes #3306

- If set (default = false) then the input will be trimmed of whitespace
  before validation and before submit

- Use trim on all input's that use the systemName validator

Signed-off-by: Sebastian Malton <sebastian@malton.name>
@Nokel81 Nokel81 added the bug Something isn't working label Jul 9, 2021
@Nokel81 Nokel81 added this to the 5.0.3 milestone Jul 9, 2021
@Nokel81 Nokel81 self-assigned this Jul 9, 2021
@Nokel81 Nokel81 requested a review from a team as a code owner July 9, 2021 19:32
@Nokel81 Nokel81 requested review from jakolehm and Nachasic and removed request for a team July 9, 2021 19:32
@Nokel81
Copy link
Collaborator Author

Nokel81 commented Jul 9, 2021

Another option could be that the default for trim is !multiline

@Nokel81 Nokel81 modified the milestones: 5.0.3, 5.1.0, 5.1.1, 5.1.2 Jul 12, 2021
@Nokel81 Nokel81 modified the milestones: 5.1.2, 5.1.3 Jul 19, 2021
Copy link
Contributor

@aleksfront aleksfront left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Nokel81 Nokel81 merged commit a4f2528 into master Jul 20, 2021
@Nokel81 Nokel81 deleted the issue-3306 branch July 20, 2021 13:30
@Nokel81 Nokel81 mentioned this pull request Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add helm repo should trim input before reporting errors
2 participants