Stop file system watchers on application quit to prevent exit code !== 0 #7504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jansav
requested review from
jim-docker and
gabriel-mirantis
and removed request for
a team
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
jansav
force-pushed
the
fix/file-system-watchers-causing-crash-on-quit
branch
from
4ea8042
to
deb65d4
Compare
Nokel81
approved these changes
Apr 5, 2023
jim-docker
approved these changes
Apr 5, 2023
|
Maybe that is the last watcher and which allows the application to close normally. Good find, can you please open a PR to explicitly close that watcher too? |
|
Doesn't it close normally after this PR? |
|
This PR looks like it closes the kubeconfig watches and the watching of extensions. I would say that we should close all watcher explicitly, just to be safe. |
|
Agreed, just wanted to confirm you weren't still seeing the error.
|
Nokel81
pushed a commit
that referenced
this pull request
Apr 5, 2023
…= 0 (#7504) * fix: Dispose the kubeconfig watcher when application quits Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * fix: Dispose the extension watcher when application quits Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> --------- Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
Nokel81
pushed a commit
that referenced
this pull request
Apr 5, 2023
…= 0 (#7504) * fix: Dispose the kubeconfig watcher when application quits Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> * fix: Dispose the extension watcher when application quits Signed-off-by: Janne Savolainen <janne.savolainen@live.fi> --------- Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
Nokel81
added a commit
that referenced
this pull request
Apr 5, 2023
Signed-off-by: Sebastian Malton <sebastian@malton.name>
Nokel81
added a commit
that referenced
this pull request
Apr 5, 2023
Signed-off-by: Sebastian Malton <sebastian@malton.name>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On application quit, the watchers should be stopped to ensure clean exit. Previously the application quit resulted in exit code
134. Before #3465, the exit code remained0but the watchers weren't cleaned explicitly.