Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to remove gateway using DNS name through leofs-adm #851

Closed
vstax opened this issue Sep 27, 2017 · 3 comments
Closed

Unable to remove gateway using DNS name through leofs-adm #851

vstax opened this issue Sep 27, 2017 · 3 comments

Comments

@vstax
Copy link
Contributor

vstax commented Sep 27, 2017

On latest develop version, I'm unable to execute "leofs-adm remove-gateway" when gateway has DNS name:

[vm@bodies-master ~]$ leofs-adm status|grep k09
  G    | gateway_k09@192.168.130.218                      | stop         | -1             | -1             | 2017-09-27 19:45:08 +0300
  G    | gateway_k09@k09.selectel.cloud.lan               | stop         | -1             | -1             | 2017-09-27 19:10:14 +0300
[vm@bodies-master ~]$ leofs-adm remove-gateway gateway_k09@192.168.130.218
OK
[vm@bodies-master ~]$ leofs-adm remove-gateway gateway_k09@k09.selectel.cloud.lan
[ERROR] Invalid arguments

Commands like "status " work fine, though. There are no errors in logs. Gateway with the same name and just IP was added later just for test (i.e. removal didn't work even before I added gateway_k09@192.168.130.218)

@mocchira
Copy link
Member

@vstax Thanks for reporting. I've found there is an unnecessary validation to check whether the latter part of the argument to remove-gateway comply with IPv4 format so I will get rid of that.

mocchira added a commit to mocchira/leofs that referenced this issue Oct 4, 2017
@mocchira
Copy link
Member

mocchira commented Oct 6, 2017

@vstax as you may know, this has been fixed on develop so please check it out if you have time.

@vstax
Copy link
Contributor Author

vstax commented Oct 11, 2017

@mocchira
This fix works, thank you.

@vstax vstax closed this as completed Oct 11, 2017
@mocchira mocchira modified the milestones: 1.4.0, 1.3.8 Oct 26, 2017
@yosukehara yosukehara added v1.3 and removed v1.4 labels Nov 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants